Clarify creating a global in Singletons (Autoload) #10416
Merged
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code below to be added to scene 1 and 2 didn't say how to define the global variable, and neither did this, so I fixed it
AThousandShips
added
enhancement
area:manual
tetrapod00
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
It's good once either of my suggestion or ATS's is applied.
Worth noting that "Global" (or whatever the PascalCase version of script filename is) does get autofilled when adding the script as a global. So the current text of the page, while technically incomplete, is a valid set of instructions, and this change is not strictly needed.
tetrapod00
changed the title
tetrapod00
changed the title
Added tetrapod's suggestion Co-authored-by: tetrapod <[email protected]>
|
@tetrapod00 added them, you could merge it now and yes, it does come in the autocomplete, but as a beginner would copy paste the code of scene 1 and 2 in the example, they might not understand that they have to do that |
|
Thanks, and congratulations on your first merged contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code written below in the page to be added to scene 1 and 2 didn't say how to define the global variable, and neither did this, so I fixed it